Well, since River Song is traveling in one direction in the time continuum relative to the Doctor, wouldn't that make the question "have they had children" rather than "should they have children"?